New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Solaris. #6578
Support Solaris. #6578
Conversation
This line is pulling in TR1, which is likely the culprit of the error: xgboost/include/xgboost/base.h Lines 57 to 59 in b2246ae
I will try to patch that line and re-submit to r-hub. |
#include <sys/sockio.h> | ||
#endif // defined(__sun) | ||
|
||
#if defined(__sun) || defined(sun) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to check both __sun
and sun
, according to dmlc/dmlc-core#549
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad that you found the test site!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's backport this patch to the |
Awesome!
Will list it. |
Codecov Report
@@ Coverage Diff @@
## master #6578 +/- ##
==========================================
+ Coverage 80.10% 80.16% +0.05%
==========================================
Files 13 13
Lines 3604 3604
==========================================
+ Hits 2887 2889 +2
+ Misses 717 715 -2
Continue to review full report at Codecov.
|
* Add system header. * Remove use of TR1 on Solaris Co-authored-by: Hyunsu Cho <chohyu01@cs.washington.edu>
* Add system header. * Remove use of TR1 on Solaris Co-authored-by: Hyunsu Cho <chohyu01@cs.washington.edu>
Related: #6542
I ran a test on https://builder.r-hub.io/ mentioned by @hcho3 . The rabit issue is fixed, but the toolchain itself on the test machine seems a bit weird.
os: Oracle Solaris 10, x86, 32 bit, R-release. A snippet of log is copied here, complete log is uploaded at the end.
log.zip