Remove instance access to SparsePage. #6590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAMitchell
approved these changes
Jan 10, 2021
trivialfis
force-pushed
the
remove-direct-inst-access
branch
from
eba4da6
to
326a2a0
Compare
hcho3
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent race access of
host_device_vector.HostVector(). We have fixed a few bugs caused by the[]operator inSparsePage, but I encountered a new one inSparsePage.GetTranspose()today. This PR is for nuking theoperator[]to prevent any related bug in the future.From now on, accessing instances in
SparsePagemust go through aSparsePageView, which contains span to host data. No change is made to GPU code since theoperator[]is not available on device code.