Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable s390x and arm64 tests on travis for now. #6641

Merged
merged 1 commit into from Jan 27, 2021

Conversation

@trivialfis trivialfis requested a review from hcho3 January 27, 2021 07:32
Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we can re-enable the arm64 test before the next release.

@hcho3
Copy link
Collaborator

hcho3 commented Jan 27, 2021

If not, we'll have to fire up an ARM64 worker on AWS and manually build the binary wheel.

@trivialfis
Copy link
Member Author

trivialfis commented Jan 27, 2021

If not, we'll have to fire up an ARM64 worker on AWS and manually build the binary wheel.

That would be quite a headache. I don't know how the monitor it, perhaps we can just merge PRs ignoring the related failures instead of disabling the tests completely?

@trivialfis
Copy link
Member Author

@hcho3 WDYT?

@hcho3
Copy link
Collaborator

hcho3 commented Jan 27, 2021

We can re-enable it once the 1.4 release gets closer

@hcho3
Copy link
Collaborator

hcho3 commented Jan 27, 2021

Adding ARM64 on Jenkins should be quite easy actually. It's just going to burn our CI budget faster.

@trivialfis
Copy link
Member Author

@hcho3 Is Windows still a bottleneck in CI spending?

@hcho3
Copy link
Collaborator

hcho3 commented Jan 27, 2021

Not any more. Now we need more of across-the-board spending cut.

@hcho3
Copy link
Collaborator

hcho3 commented Jan 27, 2021

Screen Shot 2021-01-27 at 4 50 30 PM

Now the majority of the cost is attributed to Linux.

@hcho3
Copy link
Collaborator

hcho3 commented Jan 27, 2021

Screen Shot 2021-01-27 at 4 56 15 PM

The use of multi-GPU instances incurs the highest amount of cost

@hcho3
Copy link
Collaborator

hcho3 commented Jan 27, 2021

So adding ARM64 to the matrix won't be too bad. Most of the cost comes from GPU-enabled instances.

@hcho3
Copy link
Collaborator

hcho3 commented Jan 27, 2021

Let me file a small PR today to add ARM64 worker to Jenkins.

@trivialfis trivialfis merged commit 8968ca7 into dmlc:master Jan 27, 2021
@trivialfis trivialfis deleted the disable-arm-power branch January 27, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants