[jvm] Add ability to load booster direct from byte array #6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6655 +/- ##
=======================================
Coverage 81.01% 81.01%
=======================================
Files 13 13
Lines 3703 3703
=======================================
Hits 3000 3000
Misses 703 703 Continue to review full report at Codecov.
|
|
@CodingCat please advise if there is anything else I should do to get this merged, thanks! |
|
@wbo4958 Could you please help taking a look? |
wbo4958
reviewed
Feb 22, 2021
| @@ -85,11 +85,26 @@ static Booster loadModel(InputStream in) throws XGBoostError, IOException { | |||
| os.write(buf, 0, size); | |||
| } | |||
| in.close(); | |||
| Booster ret = new Booster(new HashMap<String, Object>(), new DMatrix[0]); | |||
There was a problem hiding this comment.
maybe we can delete
static Booster loadModel(InputStream in) throws XGBoostError, IOException {and move the logic (getting buffer from InputStream) into XGBoost.java
| @@ -61,6 +61,20 @@ public static Booster loadModel(InputStream in) | |||
| return Booster.loadModel(in); | |||
There was a problem hiding this comment.
maybe we can add the logic converting InputStream into byte[] here
- move it from Booster to XGBoost facade class
honzasterba
force-pushed
the
jvm_load_booster_bytes
branch
from
c950033
to
594e872
Compare
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.