Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] Fix class Booster: feature_types = None #6705

Merged
merged 1 commit into from Feb 13, 2021

Conversation

Roffild
Copy link
Contributor

@Roffild Roffild commented Feb 13, 2021

  in get_dump
    if self.feature_types is None:
AttributeError: 'Booster' object has no attribute 'feature_types'

@codecov-io
Copy link

codecov-io commented Feb 13, 2021

Codecov Report

Merging #6705 (344cb16) into master (a4101de) will increase coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6705      +/-   ##
==========================================
+ Coverage   81.55%   81.56%   +0.01%     
==========================================
  Files          13       13              
  Lines        3719     3760      +41     
==========================================
+ Hits         3033     3067      +34     
- Misses        686      693       +7     
Impacted Files Coverage Δ
python-package/xgboost/data.py 62.63% <77.77%> (+0.07%) ⬆️
python-package/xgboost/sklearn.py 90.54% <84.00%> (-0.16%) ⬇️
python-package/xgboost/dask.py 82.57% <90.54%> (-0.10%) ⬇️
python-package/xgboost/core.py 81.94% <90.69%> (+0.09%) ⬆️
python-package/xgboost/training.py 95.60% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0399e...344cb16. Read the comment docs.

@trivialfis trivialfis merged commit 4c5d260 into dmlc:master Feb 13, 2021
@trivialfis
Copy link
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants