Throw error when using unsupported objective with predict_proba.
#6835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for now. Handling this edge case might require more efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts #6817 on the use of
softmax. Looking into it more thoroughly, thesoftmaxfunction can never appear in training due to automatic configuration infit. But the objective can still be invalid for predict_proba (likesoftmax) as illustrated in the test as an edge case. Previously I let those functions pass and may return an incorrect result. This PR reverts that part and throws a ValueError. Other than that fixes in linked PR are still useful and kept.