Handle OMP_THREAD_LIMIT in environment.
#7390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, the cause of #7156 is now known. This would be proper fix. |
|
cc @hcho3 I feel like I just did the impossible. Please review. ;-) |
hcho3
approved these changes
Nov 2, 2021
|
Nicely done! |
|
Hmm, msvc doesn't implement this environment variable. |
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 3, 2021
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 3, 2021
trivialfis
added a commit
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes R win builder.
cc @hetong007
Details,
OMP_THREAD_LIMITis an environment variable defined by OpenMP standard. Users can set it to limit the number of threads in each thread group. However, theomp_get_max_threads()function used by XGBoost is not affected by this env var. So when the env var is set, XGBoost naively thought it can obtainomp_get_max_threads()number of threads, while the received number of threads is much smaller.I ran it on win builder for a quick test https://win-builder.r-project.org/vCrjkrlXZE0l/00check.log we should run it again after backporting to 1.5 branch.