[CI] Add a helper script to aid Maven release #7470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
commented
Nov 22, 2021
jvm-packages/release_prep.py
Outdated
| output_dir = f"xgboost4j-gpu/src/main/resources/lib/{os}/{arch}" | ||
| maybe_makedirs(output_dir) | ||
| print("====Next Steps====") | ||
| print("1. Obtain Linux and Windows binaries from the CI server") |
There was a problem hiding this comment.
To automate thie step, the CI server should be configured to upload libxgboost4j.so (GPU and non-GPU version) and xgboost4j.dll in a convenient location.
hcho3
commented
Nov 22, 2021
jvm-packages/release_prep.py
Outdated
| print("====Next Steps====") | ||
| print("1. Obtain Linux and Windows binaries from the CI server") | ||
| print("2. Put them in xgboost4j(-gpu)/src/main/resources/lib/[os]/[arch]") | ||
| print("3. Now run 'mvn release' on a Mac machine") |
There was a problem hiding this comment.
Hopefully, we can configure GitHub Actions to build libxgboost4j.dylib automatically.
hcho3
commented
Nov 22, 2021
jvm-packages/release_prep.py
Outdated
Comment on lines
48
to
51
| print("====copying pure-Python tracker====") | ||
| for use_cuda in [True, False]: | ||
| xgboost4j = "xgboost4j-gpu" if use_cuda else "xgboost4j" | ||
| cp("../python-package/xgboost/tracker.py", f"{xgboost4j}/src/main/resources") |
There was a problem hiding this comment.
This step ensures that we don't repeat the same mistake as #7449
trivialfis
reviewed
Nov 23, 2021
trivialfis
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper script will ensure that not a single step is left out in the release process for the JVM packages. Related: #7449
@trivialfis There are many manual steps in the current process for Maven release. I'd like to automate them eventually. For now, I've created a helper script to ensure that all steps are followed.