Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Export function xgb.shap.data #7471

Closed
wants to merge 1 commit into from
Closed

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Nov 23, 2021

https://discuss.xgboost.ai/t/xgb-shap-data-not-found/2557?u=hcho3

Even though the utility function xgb.shap.data was visible in the R-package documentation (here), it was not explicitly published from NAMESPACE. The function should be exported so that it can be actually used.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the user actually need to call that function in order to use SHAP related features? Just curious since it's a new public API function.

@hcho3
Copy link
Collaborator Author

hcho3 commented Nov 23, 2021

@trivialfis
Copy link
Member

If no one can use it, let's remove the public document instead. ;-)

@trivialfis
Copy link
Member

I will leave it for you to decide. I'm not familiar with R so I worried about a new function to maintain. If you think it's best to export the function then this PR looks good to me.

@hcho3 hcho3 closed this Mar 22, 2022
@hcho3 hcho3 deleted the export_shap_data branch March 22, 2022 23:34
@hcho3
Copy link
Collaborator Author

hcho3 commented Mar 22, 2022

Closing this, as xgb.shap.data was marked as internal in #6374, and the document has been regenerated. https://github.com/dmlc/xgboost/blob/master/R-package/man/xgb.plot.shap.Rd no longer shows xgb.shap.data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants