Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maximum category in sketch. #7853

Merged
merged 13 commits into from
May 5, 2022
Merged

Conversation

trivialfis
Copy link
Member

Close #7851 .

src/common/quantile.cc Outdated Show resolved Hide resolved
src/common/quantile.cc Outdated Show resolved Hide resolved
src/common/quantile.cu Outdated Show resolved Hide resolved
src/common/quantile.cu Outdated Show resolved Hide resolved
src/common/quantile.cu Show resolved Hide resolved
@trivialfis
Copy link
Member Author

@hcho3 All comments are resolved.

@trivialfis
Copy link
Member Author

let's don't merge it for now.

@trivialfis
Copy link
Member Author

NVM, it's fine now. I was afraid that might break one-hot encoding.

@trivialfis
Copy link
Member Author

@hcho3 Could you please take another look when you are available?

@trivialfis trivialfis merged commit 46e0bce into dmlc:master May 5, 2022
@trivialfis trivialfis deleted the fix-cat-max branch May 5, 2022 11:56
trivialfis added a commit to trivialfis/xgboost that referenced this pull request May 6, 2022
trivialfis added a commit to trivialfis/xgboost that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable_categorical=True results in error code 0xc0000409
2 participants