Add back xgboost.rabit for backwards compatibility #8408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
approved these changes
Nov 1, 2022
trivialfis
reviewed
Nov 2, 2022
| return collective.get_rank() | ||
|
|
||
|
|
||
| def get_world_size() -> int: |
There was a problem hiding this comment.
get_world_size = collective.get_world_size
There was a problem hiding this comment.
And similarly for others. Not a request for change, just suggestions.
There was a problem hiding this comment.
Let's keep it as it is; the alternative seems less clear to me
trivialfis
approved these changes
Nov 2, 2022
trivialfis
reviewed
Nov 2, 2022
hcho3
added a commit
to hcho3/xgboost
that referenced
this pull request
Nov 2, 2022
* Add back xgboost.rabit for backwards compatibility * fix my errors * Fix lint * Use FutureWarning Co-authored-by: Hyunsu Philip Cho <chohyu01@cs.washington.edu>
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8406 by making
xgboost.rabitavailable in 1.7. Also add a warning to direct users to usexgboost.collectiveinstead.