-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work with newer thrust and libcudacxx #8432
Work with newer thrust and libcudacxx #8432
Conversation
When xgboost is brought into a large project it can be compiled against Thrust 1.17+ which don't offer this experimental allocator. To ensure that going forward xgboost works in all enviornments we provide a xgboost namespaced version of the pinned_allocator that previously was in Thrust.
Thank you for working on this, I saw NVIDIA/cccl#730 , which mentioned a new |
That is an option but it will cause a larger change to xgboost. The big difference between this allocator and If you prefer that solution I am happy to update the pr to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's continue with the current approach. Could you please address the linter errors?
078d2d9
to
8907376
Compare
@trivialfis Style issues have been fixed. |
I just triggered the GPU CI, could you please address the remaining errors: |
The latest rounds of fixes should handle the clang tidy and java failures. For clang tidy I had to suppress most things due to meeting the std::allocator requirements, and the CUDA rules around |
Could you please add a NOLINT mark to rebind for clang tidy? |
Done |
I didn't notice the change was done on 1.7, could you please port it to master as well? |
Opened #8454 for that |
No description provided.