Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-packages] Add missing commons-lang3 dependency to xgboost4j-gpu #8508

Merged
merged 2 commits into from Dec 2, 2022

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Dec 1, 2022

The CI broke at the trunk branch with error

[ERROR] /workspace/jvm-packages/xgboost4j-gpu/src/test/java/ml/dmlc/xgboost4j/gpu/java/DMatrixTest.java:[27,31] package org.apache.commons.lang does not exist
[ERROR] /workspace/jvm-packages/xgboost4j-gpu/src/test/java/ml/dmlc/xgboost4j/gpu/java/DMatrixTest.java:[122,59] cannot find symbol
symbol: variable ArrayUtils
location: class ml.dmlc.xgboost4j.gpu.java.DMatrixTest

(https://buildkite.com/xgboost/xgboost-ci/builds/819#0184cc80-908c-4e39-9c79-1f56976d2692)

Fix. Specify commons-lang3 package as an explicit dependency of xgboost4j-gpu.

@hcho3
Copy link
Collaborator Author

hcho3 commented Dec 1, 2022

@wbo4958 Can I get a review?

Copy link
Contributor

@wbo4958 wbo4958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hcho3 hcho3 merged commit 2546d13 into dmlc:master Dec 2, 2022
@hcho3 hcho3 deleted the fix_jvm_ci branch December 2, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants