Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading GPU pickle with a CPU-only xgboost distribution. #8632

Merged
merged 1 commit into from Jan 4, 2023

Conversation

trivialfis
Copy link
Member

We can handle loading the pickle on a CPU-only machine if the XGBoost is built with CUDA enabled (Linux and Windows PyPI package), but not if the distribution is CPU-only (macOS PyPI package).

To reproduce the error: train a model with GPU hist. Load it with an XGBoost build that doesn't have CUDA capability.

Close #8615 .

We can handle loading the pickle on a CPU only machine if the XGBoost is built with CUDA
enabled (Linux and Windows PyPI package), but not if the distribution is CPU-only (macos
PyPI package).

To reproduce the error: train a model with GPU hist. Load it with a XGBoost build that
doesn't have CUDA capability.
@trivialfis
Copy link
Member Author

This is a quick fix meant for backporting, once I clear the backlog for other PRs I will focus on #7308 instead.

@trivialfis trivialfis merged commit 26c9882 into dmlc:master Jan 4, 2023
@trivialfis trivialfis deleted the load-gpu-pkl branch January 4, 2023 18:14
@trivialfis trivialfis added this to Bug fixes in 1.7.3 patch release Jan 4, 2023
trivialfis added a commit to trivialfis/xgboost that referenced this pull request Jan 5, 2023
We can handle loading the pickle on a CPU-only machine if the XGBoost is built with CUDA
enabled (Linux and Windows PyPI package), but not if the distribution is CPU-only (macOS
PyPI package).
trivialfis added a commit that referenced this pull request Jan 5, 2023
…n. (#8632) (#8641)

We can handle loading the pickle on a CPU-only machine if the XGBoost is built with CUDA
enabled (Linux and Windows PyPI package), but not if the distribution is CPU-only (macOS
PyPI package).
@trivialfis trivialfis moved this from Bug fixes to Backported in 1.7.3 patch release Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

macOS incompatibility
2 participants