Fix ranking with quantile dmatrix and group weight. #8762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAMitchell
reviewed
Feb 9, 2023
| @@ -63,6 +63,13 @@ void GetCutsFromRef(std::shared_ptr<DMatrix> ref_, bst_feature_t n_features, Bat | |||
| } | |||
| }; | |||
| auto ellpack = [&]() { | |||
| // workaround ellpack being initialized from CPU. | |||
| if (p.gpu_id == Context::kCpuId) { | |||
There was a problem hiding this comment.
I don't understand what is happening here, and it looks weird with two statements having the same condition.
There was a problem hiding this comment.
If the device is on CPU, we try the device ordinal in reference dmatrix. After the assignment from the reference dmatrix, if the device is still on cpu, we just use 0 as a workaround.
This happens when both the current qdm and the reference dmatrix are initialized with CPU data, but we train the booster on GPU, which requests the ellpack from DMatrix but the DMatrix is on CPU.
I'm working to unify the device ordinal, we will have a single context from booster instead. This PR is a quick fix for backport.
RAMitchell
approved these changes
Feb 10, 2023
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Feb 14, 2023
trivialfis
added a commit
that referenced
this pull request
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #8708 .