Define git attributes for renormalization. #8921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
reviewed
Mar 15, 2023
Comment on lines
+3
to
+12
| *.c text eol=lf | ||
| *.h text eol=lf | ||
| *.cc text eol=lf | ||
| *.cuh text eol=lf | ||
| *.cu text eol=lf | ||
| *.py text eol=lf | ||
| *.txt text eol=lf | ||
| *.R text eol=lf | ||
| *.scala text eol=lf | ||
| *.java text eol=lf |
There was a problem hiding this comment.
Why convert to LF even on Windows?
There was a problem hiding this comment.
I think it's just a problem of picking one in a platform-independent manner, instead of having mixed newline symbols. I accidentally removed a carriage on the partition builder, and here is the warning from cpplint for using mixed newline symbol:
src/common/partition_builder.h:371: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
src/common/partition_builder.h:372: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
src/common/partition_builder.h:373: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
src/common/partition_builder.h:374: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
src/common/partition_builder.h:375: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
src/common/partition_builder.h:376: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
src/common/partition_builder.h:377: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
src/common/partition_builder.h:378: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
src/common/partition_builder.h:379: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
src/common/partition_builder.h:380: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
src/common/partition_builder.h:381: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
src/common/partition_builder.h:382: Unexpected \r (^M) found; better to use only \n [whitespace/newline] [1]
....
hcho3
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle text line ending automatically.
All changes are made by git 2.39.2. Git will carry out the change automatically before you commit.
Document for the behavior: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings