Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify char type in JSON. #8949

Merged
merged 4 commits into from Mar 22, 2023
Merged

Specify char type in JSON. #8949

merged 4 commits into from Mar 22, 2023

Conversation

trivialfis
Copy link
Member

char is defined as signed on x86 but unsigned on arm64

  • Use std::int8_t instead of char.
  • Fix include when clang is pretending to be gcc.

@trivialfis
Specify char type in JSON.
11fe473 
char is defined as signed on x86 but unsigned on arm64
@trivialfis
include.
0e4832d
@trivialfis
to string.
fdc9cbf
@trivialfis
lint.
047e45c
@trivialfis trivialfis merged commit a05799e into dmlc:master Mar 22, 2023
21 checks passed
@trivialfis trivialfis deleted the specify-char-type branch March 22, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trivialfis @RAMitchell