Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer overflow. #9380

Merged
merged 3 commits into from Jul 15, 2023
Merged

Fix integer overflow. #9380

merged 3 commits into from Jul 15, 2023

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Jul 12, 2023 •
edited

Close #9334

todos:

  • Tests.

@trivialfis trivialfis marked this pull request as ready for review July 13, 2023 05:10
@trivialfis trivialfis changed the title [WIP] Fix integer overflow. Fix integer overflow. Jul 13, 2023
@trivialfis
Copy link
Member Author

We are likely to see some other issues with H100, at the moment I haven't been able to work on extensive tests as other libraries are not yet compatible with sm90.

@WeichenXu123
Copy link
Contributor

Can we backport this to 1.7.x ?

@WeichenXu123 WeichenXu123 mentioned this pull request Jul 13, 2023
Closed
@trivialfis trivialfis merged commit 0a07900 into dmlc:master Jul 15, 2023
25 checks passed
@trivialfis trivialfis deleted the fix-overflow branch July 15, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Large datasets in R / Nvidia H100s cause unexpected memory overflow error
3 participants
@trivialfis @WeichenXu123 @RAMitchell