[R] Enable booster slicing #9948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apologies for the difficulty of stacking PRs, I will try to look into #9924 as soon as possible. |
david-cortes
force-pushed
the
slice_booster
branch
from
cfc79db
to
e4db759
Compare
trivialfis
reviewed
Jan 14, 2024
| @@ -62,6 +64,7 @@ export(xgb.plot.tree) | |||
| export(xgb.save) | |||
| export(xgb.save.raw) | |||
| export(xgb.set.config) | |||
| export(xgb.slice.Booster) | |||
There was a problem hiding this comment.
Is this still needed after having the s3 method?
There was a problem hiding this comment.
It's not needed, but I think it helps with discoverability compared to having just an S3 method.
There was a problem hiding this comment.
Thank you for sharing, sounds good!
trivialfis
approved these changes
Jan 20, 2024
david-cortes
force-pushed
the
slice_booster
branch
from
50b17e5
to
c5d0608
Compare
|
Sorry - I'm not sure what happened here. Looks like the PR somehow closed itself after force-pushing, and shows it has being merged already, which it isn't. Looks like I cannot reopen it from here either. EDIT: figured out I had pushed the wrong commit. Now it should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9810
To be rebased after PR #9924 is merged, as it contains the commits from it.
This PR adds a wrapper over the C function to slice booster rounds.
The slicing logic is made in such a way that it maches with R's syntax for sequences, but there were some issues from the C-level function as described in previous issue: #9944
so the tests aren't very comprehensive