Reflect TCK test cases errorResult flag where missing #359

tarilabs · 2020-03-03T09:22:46Z

No description provided.

StrayAlien · 2020-03-03T09:29:24Z

Hi @tarilabs - I hope you are well and enjoying the start of spring. Nice to see some activity here. We're just going into autumn. :-) I'll be able to check this in practice maybe this weekend. At one stage I did turn on a flag to see whether we had this flag set in all places correctly and I recall there being quite a few places where it was not. I'll check.

tarilabs · 2020-03-03T09:26:41Z

TestCases/compliance-level-3/0059-feel-all-function/0059-feel-all-function-test-01.xml

@@ -37,7 +37,7 @@

    <testCase id="004">
        <description>return null if any item is not true or false</description>
-        <resultNode name="decision004" type="decision">
+        <resultNode errorResult="true" name="decision004" type="decision">


Case:

tck/TestCases/compliance-level-3/0059-feel-all-function/0059-feel-all-function.dmn

Line 37 in 9f8ba50

<text>all([true, 123, true])</text>

DMN Spec:

list of Boolean items

Concur in the result, but I believe is missing the errorFlag to clarify this is an error case

tarilabs · 2020-03-03T09:28:12Z

TestCases/compliance-level-3/0059-feel-all-function/0059-feel-all-function-test-01.xml

@@ -73,7 +73,7 @@

    <testCase id="008">
        <description>return null for singleton null</description>
-        <resultNode name="decision008" type="decision">
+        <resultNode errorResult="true" name="decision008" type="decision">


Case:

tck/TestCases/compliance-level-3/0059-feel-all-function/0059-feel-all-function.dmn

Line 73 in 9f8ba50

<text>all(null)</text>

DMN Spec:

list of Boolean items or argument list of one or more Boolean items

Concur in the result, but I believe is missing the errorFlag to clarify this is an error case

tarilabs · 2020-03-03T09:29:13Z

TestCases/compliance-level-3/0059-feel-all-function/0059-feel-all-function-test-01.xml

@@ -82,7 +82,7 @@

    <testCase id="009">
        <description>return null for singleton non-boolean</description>
-        <resultNode name="decision009" type="decision">
+        <resultNode errorResult="true" name="decision009" type="decision">


Case:

tck/TestCases/compliance-level-3/0059-feel-all-function/0059-feel-all-function.dmn

Line 82 in 9f8ba50

<text>all(123)</text>

DMN Spec:

list of Boolean items or argument list of one or more Boolean items

Concur in the result, but I believe is missing the errorFlag to clarify this is an error case

tarilabs · 2020-03-03T09:31:32Z

TestCases/compliance-level-3/0059-feel-all-function/0059-feel-all-function-test-01.xml

@@ -118,7 +118,7 @@

    <testCase id="013">
        <description>return null if any vararg item is not true or false</description>
-        <resultNode name="decision013" type="decision">
+        <resultNode errorResult="true" name="decision013" type="decision">


Case:

tck/TestCases/compliance-level-3/0059-feel-all-function/0059-feel-all-function.dmn

Line 122 in 9f8ba50

<text>all(true, 123, true)</text>

DMN Spec:

list of Boolean items or argument list of one or more Boolean items

Concur in the result, but I believe is missing the errorFlag to clarify this is an error case

tarilabs · 2020-03-03T09:33:14Z

TestCases/compliance-level-3/0060-feel-any-function/0060-feel-any-function-test-01.xml

@@ -27,7 +27,7 @@

    <testCase id="004">
        <description>return null if any item not true and not all false</description>
-        <resultNode name="decision004" type="decision">
+        <resultNode errorResult="true" name="decision004" type="decision">


Case:

tck/TestCases/compliance-level-3/0060-feel-any-function/0060-feel-any-function.dmn

Line 30 in 9f8ba50

<text>any([123, false])</text>

DMN Spec:

list of Boolean items or argument list of one or more Boolean items

Concur in the result, but I believe is missing the errorFlag to clarify this is an error case

tarilabs · 2020-03-03T09:35:24Z

TestCases/compliance-level-3/0066-feel-negation/0066-feel-negation-test-01.xml

@@ -32,23 +32,23 @@
    </testCase>

    <testCase id="003_b">
-        <resultNode name="decision003_b" type="decision">
+        <resultNode errorResult="true" name="decision003_b" type="decision">


Case:

tck/TestCases/compliance-level-3/0066-feel-negation/0066-feel-negation.dmn

Line 40 in 9f8ba50

<text>not(0)</text>

DMN Spec:

Parameter Domain: boolean

Concur in the result, but I believe is missing the errorFlag to clarify this is an error case

tarilabs · 2020-03-03T09:35:46Z

TestCases/compliance-level-3/0066-feel-negation/0066-feel-negation-test-01.xml

            <expected>
                <value xsi:nil="true"/>
            </expected>
        </resultNode>
    </testCase>

    <testCase id="003_c">
-        <resultNode name="decision003_c" type="decision">
+        <resultNode errorResult="true" name="decision003_c" type="decision">


Case:

tck/TestCases/compliance-level-3/0066-feel-negation/0066-feel-negation.dmn

Line 50 in 9f8ba50

<text>not(1)</text>

DMN Spec:

Parameter Domain: boolean

Concur in the result, but I believe is missing the errorFlag to clarify this is an error case

tarilabs · 2020-03-03T09:35:59Z

TestCases/compliance-level-3/0066-feel-negation/0066-feel-negation-test-01.xml

            <expected>
                <value xsi:nil="true"/>
            </expected>
        </resultNode>
    </testCase>

    <testCase id="003_d">
-        <resultNode name="decision003_d" type="decision">
+        <resultNode errorResult="true" name="decision003_d" type="decision">


Case:

tck/TestCases/compliance-level-3/0066-feel-negation/0066-feel-negation.dmn

Line 60 in 9f8ba50

<text>not("true")</text>

DMN Spec:

Parameter Domain: boolean

Concur in the result, but I believe is missing the errorFlag to clarify this is an error case

tarilabs · 2020-03-03T09:38:01Z

...Cases/compliance-level-3/0080-feel-getvalue-function/0080-feel-getvalue-function-test-01.xml

-        <description>null value stored in context</description>
-        <resultNode name="decision_011" type="decision">
+        <description>null map and key params</description>
+        <resultNode errorResult="true" name="decision_011" type="decision">


Test case:

tck/TestCases/compliance-level-3/0080-feel-getvalue-function/0080-feel-getvalue-function.dmn

Line 113 in 9f8ba50

<text>get value(null, null)</text>

So this is about extracting the entry null in a null context, not the original submission.
Reflecting on the correct test DMN model decision logic.
Additionally, this is an error case, putting the flag.

tarilabs · 2020-03-03T09:39:46Z

...Cases/compliance-level-3/0080-feel-getvalue-function/0080-feel-getvalue-function-test-01.xml

            <expected>
                <value xsi:nil="true"></value>
            </expected>
        </resultNode>
    </testCase>

+    <testCase id="decision_012">
+        <description>null value stored in context</description>


the original submission for

null value stored in context

shall refer, I believe, to test case:

tck/TestCases/compliance-level-3/0080-feel-getvalue-function/0080-feel-getvalue-function.dmn

Line 123 in 9f8ba50

<text>get value({a: null}, "a")</text>

which is decision logic decision decision_012 .

Created accordingly and aligned, a non-error test case where the expected result is the null stored in the context entry for "a".

tarilabs · 2020-03-03T09:51:00Z

Ciao @StrayAlien hope all is fine with you too, despite I've heard this Australian summer was problematic in terms of wildfires. We are experiencing quite some difficulties here due to COVID-19 but trying to manage somehow.

Just a brief reminder this TCK flag is meant to hint, in my understanding from original TCK decisions.

The reason I raised this PR. We improved on Drools DMN engine side some small bits here and there, I noticed at the same time these flags might have been missing from the TCK, so I thought worthy to align them, in the hope this helps other TCK result submitters.

…sult flag

tarilabs · 2020-05-03T07:36:34Z

As discussed at TCK meeting 2020-04-24, will proceed to merge.

Reflect TCK test cases errorResult flag where missing

45d3d8e

tarilabs commented Mar 3, 2020

View reviewed changes

tarilabs added a commit to tarilabs/dmn-tck that referenced this pull request Apr 8, 2020

ASSUME dmn-tck#359 Drools runner update to consistency of TCK errorRe…

d79182b

…sult flag

tarilabs merged commit db0ff30 into dmn-tck:master May 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reflect TCK test cases errorResult flag where missing #359

Reflect TCK test cases errorResult flag where missing #359

tarilabs commented Mar 3, 2020

StrayAlien commented Mar 3, 2020

tarilabs Mar 3, 2020

tarilabs Mar 3, 2020

tarilabs Mar 3, 2020

tarilabs Mar 3, 2020

tarilabs Mar 3, 2020

tarilabs Mar 3, 2020

tarilabs Mar 3, 2020

tarilabs Mar 3, 2020

tarilabs Mar 3, 2020

tarilabs Mar 3, 2020

tarilabs commented Mar 3, 2020

tarilabs commented May 3, 2020

Reflect TCK test cases errorResult flag where missing #359

Reflect TCK test cases errorResult flag where missing #359

Conversation

tarilabs commented Mar 3, 2020

StrayAlien commented Mar 3, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarilabs commented Mar 3, 2020

tarilabs commented May 3, 2020