Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rsync to Dockerfile #38

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Adding rsync to Dockerfile #38

merged 2 commits into from
Oct 18, 2021

Conversation

lukasklein
Copy link
Contributor

@lukasklein lukasklein commented Oct 12, 2021

This fixes a bug introduced by a "#hacktoberfest" PR (#37) that clearly wasn't tested and just replaced one command to collect "contributions" to an open-source project.

@RossMurr4y
Copy link

Might be a good idea to update the README here too.

source_file: The file or directory to be moved. Uses the same syntax as the cp command. Incude the path for any files not in the repositories root directory.

The change from cp to rsync is pretty significant to the way this input works.

@lukasklein
Copy link
Contributor Author

Good point @RossMurr4y!

@dmnemec
Copy link
Owner

dmnemec commented Oct 18, 2021

Was out of town for work, just got back and saw this. I think it should actually revert it back to cp for now and test rsync on a different branch since it could have more impact that I initially thought.

@dmnemec dmnemec added bug Something isn't working hacktoberfest-accepted labels Oct 18, 2021
@dmnemec dmnemec merged commit 77d19f4 into dmnemec:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants