Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle_left_release(event) in Table only checks if column is categorical but not editable. #248

Closed
JoseDataScience opened this issue Nov 22, 2023 · 1 comment

Comments

@JoseDataScience
Copy link

I don't believe this is the intended behavior.

Instead of only having:

if dtype.name == 'category':

I believe it should be:

if self.editable and dtype.name == 'category':

As it stands you can make edits to categorical columns even when the table itself isn't editable. This is not an issue when double clicking to edit non-categorical columns (which is analogous behavior). In handle_double_click() there is a call to drawCellEntry() which does check for self.editable and prevents editing.

Should be a quick fix if this behavior isn't intended.

@dmnfarrell
Copy link
Owner

should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants