Fixed issue #58, #75 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I see, the previous fix of the issue dmnfarrell#58 only adds the `sep` parameter to the `Tables.importCSV` function, which prevents the `unexpected keyword argument 'sep'` error, but the `sep` parameter is still not passed to the `TableModels.importCSV` function, so the default separator is used anyway.
dmnfarrell
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I see, the previous fix of the issue #58 only adds the
sepparameter to theTables.importCSVfunction, which prevents theunexpected keyword argument 'sep'error, but thesepparameter is still not passed to theTableModels.importCSVfunction, so the default separator is used anyway.A newer issue #75 looks related to the same problem.