Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eject encodeAny, decodeAny from buffer - fixes #19 #56

Closed
wants to merge 2 commits into from
Closed

Eject encodeAny, decodeAny from buffer - fixes #19 #56

wants to merge 2 commits into from

Conversation

oscarhermoso
Copy link

@oscarhermoso oscarhermoso commented Feb 24, 2023 •
edited
Loading

Having some trouble adding playwright to my project because of circular dependencies.

Screenshot from 2023-02-24 12-01-14

This PR moves the encodeAny and decodeAny methods from buffer to encoding and decoding respectively.

fixes #16, #19, #51

@dmonad
Copy link
Owner

dmonad commented Oct 13, 2023 •
edited
Loading

I can't merge this as it would break all packages that depend on lib0/buffer/encodeAny

@dmonad dmonad closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circular dependency between buffer.js, encoding.js, and decoding.js
2 participants
@oscarhermoso @dmonad