Trivial nitpicks for e4defrag2 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STATE: "Wed Jul 23 16:14:42 MSK 2014"
1-3 stages are fully functional
4: [In progress] Kernel part is functional and submitted here:
http://marc.info/?l=linux-ext4&m=140606283832640
TODO:
- Implement good algo for finding local donor
May be simply add ioctl for mballoc
- Cleanup debug for flex_bg
- Cleanup usless debugging.
This is obviously logical typo. We have to scan only ones which are (rfh->flags & SP_FL_IEF_RELOC) && (!rfh->flags & SP_FL_IGNORE)
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
These are mostly typos, plus some whitespace nitpicks, missing commas, missing articles and so on. Of particular interest here is the amount of ways to misspell the word "defragmentation". Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Argument mntid of name_to_handle_at() should be "int", not "unsigned
int". Fixes a bunch of compiler warnings like this one:
e4defrag2.c:890:44: warning: pointer targets in passing argument 4 of ‘name_to_handle_at’ differ in signedness [-Wpointer-sign]
ret = name_to_handle_at(dirfd, name, fhp, &mnt, 0);
^
In file included from /usr/include/bits/fcntl.h:61:0,
from /usr/include/fcntl.h:35,
from e4defrag2.c:25:
/usr/include/bits/fcntl-linux.h:406:12: note: expected ‘int *’ but argument is of type ‘unsigned int *’
extern int name_to_handle_at (int __dfd, const char *__name,
^
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong branch, please ignore