Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license injector #5

Closed
wants to merge 1 commit into from
Closed

Add license injector #5

wants to merge 1 commit into from

Conversation

dmreagan
Copy link
Owner

@dmreagan dmreagan commented Feb 7, 2019

I recently learned of the recommendations from the IU Open Source Administrators. They include licensing with BSD-3 and inserting license and copyright info into all source files. This PR adds an npm script which automatically checks for the info and inserts it if it is missing. It can also be configured to search for and remove license info if we need to change things later.

We'll need to check with the Immersive Scholar folks to see if BSD-3 works for them.

@dmreagan dmreagan added the enhancement New feature or request label Feb 7, 2019
@guangchen guangchen closed this Feb 8, 2019
@guangchen
Copy link
Collaborator

Merged license branch into master

@dmreagan
Copy link
Owner Author

dmreagan commented Feb 8, 2019

@guangchen, it looks like you forgot to merge

@dmreagan dmreagan reopened this Feb 8, 2019
@guangchen
Copy link
Collaborator

guangchen commented Feb 8, 2019

Need to rollback to previous commit since I found the license branch raises "Access to XMLHttpRequest at XXXX has been blocked by CORS policy" error. I suspect this is brought by some newly introduced dependencies in package.json. Dave can you please verify this issue?

@dmreagan
Copy link
Owner Author

dmreagan commented Feb 8, 2019

Could it be a problem with the injected license info in one of the files? Like maybe it wasn't commented correctly, or there's a problem having comments at the top of the file? Please check the extra license_formats I had to provide in package.json for any mistakes. The only dependency added to package.json is the utility for injecting the license info, which only runs when you manually execute it.

@dmreagan dmreagan mentioned this pull request Oct 31, 2019
@dmreagan
Copy link
Owner Author

dmreagan commented Nov 6, 2019

Going with #57 for now. May return to this later for individual file injection.

@dmreagan dmreagan closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants