Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long tracks may render as flat line #12

Closed
dmrschmidt opened this issue Mar 20, 2019 · 0 comments
Closed

Long tracks may render as flat line #12

dmrschmidt opened this issue Mar 20, 2019 · 0 comments

Comments

@dmrschmidt
Copy link
Owner

Due to undersampling, when downSampledLength in let downSampledLength = sampleLength / samplesPerPixel results in 0 length.

Related to #8
dmrschmidt pushed a commit that referenced this issue Mar 20, 2019
ensure we always render waveform, even for large files #12
eab0cac 
prevents undersampling; still getting a weird offset, related to #8
dmrschmidt pushed a commit that referenced this issue Mar 20, 2019
make sure all samples get used within vDSP_desamp
e05826c 
makes sure we're not leaving samples unprocessed as vDSP_desamp only works in strides. We keep the
unprocessed samples in the running buffer for the next assets reads.

We still have a small buffer potentially at the end which we'll need to consume to really parse the entire track. Coming soon.

#8, #12
@dmrschmidt dmrschmidt mentioned this issue Mar 20, 2019
Closed
dmrschmidt added a commit that referenced this issue Mar 21, 2019
@dmrschmidt
process remaining samples after whole asset is read
7c102d5 
There may be unprocessed samples in the sample buffer after finalizing the initial processing-while-reading.
This would also result in less-than-required pixels being rendered. We backfill the missing buffer to be a
multiple of samplesPerPixel so vDSP_desamp will consume all of them.

finishes #8, #12
@dmrschmidt dmrschmidt mentioned this issue Mar 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmrschmidt