Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to AdminLTE 2.4.9 #186

Closed
daniele-athome opened this issue Mar 10, 2019 · 5 comments
Closed

Update to AdminLTE 2.4.9 #186

daniele-athome opened this issue Mar 10, 2019 · 5 comments

Comments

@daniele-athome
Copy link

Just a reminder:

https://github.com/almasaeed2010/AdminLTE/releases/tag/v2.4.9

Thank you :-)

@schmunk42
Copy link
Member

GitMate.io thinks possibly related issues are #125 (Update to AdminLTE 2.4), #132 (after updated almasaeed2010/adminlte to 2.4 package have an issue), #18 (AdminLTE v.2), #118 (error installing yii2-adminlte-asset "2.*"), and #140 (AdminLTE webfont inclusion (update documentation needed)).

@schmunk42
Copy link
Member

We are requiring ^2.4.0, so you should get 2.4.9 when running composer update.

But be aware of #185

@daniele-athome
Copy link
Author

We are requiring ^2.4.0, so you should get 2.4.9 when running composer update.

Sure, but I thought that probably your composer.lock should be updated as well.

But be aware of #185

That was my laziness talking :-) I'll have a look and make a PR when I have some time.

@schmunk42
Copy link
Member

Sure, but I thought that probably your composer.lock should be updated as well.

That's just for testing ;) It has no effect on your project. But actually we don't run automated tests here.

@daniele-athome
Copy link
Author

That's just for testing ;) It has no effect on your project. But actually we don't run automated tests here.

I know, it was just a matter of keeping stuff aligned that's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants