-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/wysiwyg editors #37
Feature/wysiwyg editors #37
Conversation
src/JoditAsset.php
Outdated
|
||
class JoditAsset extends AssetBundle | ||
{ | ||
public $sourcePath = '@dmstr/jsoneditor/assets/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use @dmstr/jsoneditor/assets/jodit here to prevent publishing unwanted files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or why do we not use the files in /assets/jodit
src/SceditorAsset.php
Outdated
|
||
class SceditorAsset extends AssetBundle | ||
{ | ||
public $sourcePath = '@dmstr/jsoneditor/assets/sceditor/minified'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we not use the files in /assets/sceditor/minified?
src/JsonEditorWidget.php
Outdated
} | ||
}'; | ||
|
||
$json = Yii::$app->settings->getOrSet('jodit.config', $joditConfig, 'jsoneditor', 'object'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Settings should be optional - see: #13
Why are the assets bundles not in the |
Ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include the LICENSE files and a note in the README about the bundled assets.
This pull request is no longer WIP. Should i merge and tag? |
Yes, go ahead. |
Alternatives for CKEditor: Jodit and SCEditor
Markdown editor: simpleMDE