New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

languages array to lowercase #26

Merged

handcode merged 1 commit into dmstr:master from germanbisurgi:master

Dec 12, 2017

germanbisurgi commented Dec 8, 2017

No description provided.


          languages array to lowercase

4b3dc5c

Member

schmunk42 commented Dec 8, 2017

I think we should not enforce this.

CC: @marc7000 @handcode WDYT?

Member

handcode commented Dec 11, 2017 •

edited

Loading

$language in pages is lowercased in DefaultController, therefore i think it's consistent to lowercase it in all places.

yii2-pages-module/controllers/DefaultController.php

Line 32 in 484efcd

$language = mb_strtolower(\Yii::$app->language);

handcode merged commit aa21ad3 into dmstr:master

Member

handcode commented Dec 12, 2017

available in https://github.com/dmstr/yii2-pages-module/releases/tag/0.22.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment