Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization support #43

Merged
merged 11 commits into from
Dec 30, 2016
Merged

Add serialization support #43

merged 11 commits into from
Dec 30, 2016

Conversation

dmsurti
Copy link
Owner

@dmsurti dmsurti commented Dec 30, 2016

This adds the serialization support.

Refactored the SCNAssimpScene so that it generates a model SCNScene and an array of animation SCNScene's. By transforming to the SCNScene instance, serialization does not need any custom changes.

The tests are now updated and the test criteria is both the validity of the generated SCNScene as well as it's full serialization. mdl support dropped as a result.

The API has changed and is simpler, with just addition of an SCNScene animation to a given SCNScene model.

The example projects and documentation updated as per the API changes.

@dmsurti dmsurti added this to the Serialization milestone Dec 30, 2016
@dmsurti dmsurti self-assigned this Dec 30, 2016
@codecov-io
Copy link

codecov-io commented Dec 30, 2016

Current coverage is 76.33% (diff: 78.43%)

Merging #43 into master will decrease coverage by 5.15%

@@             master        #43   diff @@
==========================================
  Files             9         11     +2   
  Lines          1232       1293    +61   
  Methods          81        101    +20   
  Messages          0          0          
  Branches        103        110     +7   
==========================================
- Hits           1004        987    -17   
- Misses          171        249    +78   
  Partials         57         57          

Powered by Codecov. Last update 66505d4...9add299

@dmsurti dmsurti merged commit 418d0b1 into master Dec 30, 2016
@dmsurti dmsurti deleted the serialize branch December 31, 2016 05:53
This was referenced Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants