Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mallocate memory when making source buffers for scenekit sources. #59

Merged
merged 15 commits into from
Sep 1, 2017

Conversation

dmsurti
Copy link
Owner

@dmsurti dmsurti commented Aug 17, 2017

When we import large models as reported in GH Issue #56 and #58,
allocating memory for the buffers on the stack won't work, so we
explicilty allocate it on the heap and free this memory once the
scenekit sources have been generated from these source buffers.

Fixes for #56, #58.

When we import large models as reported in GH Issue # 56 and # 58,
allocating memory for the buffers on the stack won't work, so we
explicilty allocate it on the heap and free this memory once the
scenekit sources have been generated from these source buffers.
@codecov-io
Copy link

codecov-io commented Aug 17, 2017

Codecov Report

Merging #59 into master will decrease coverage by 1.46%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   69.13%   67.66%   -1.47%     
==========================================
  Files          14       14              
  Lines        1419     1429      +10     
  Branches      125      127       +2     
==========================================
- Hits          981      967      -14     
- Misses        381      399      +18     
- Partials       57       63       +6
Impacted Files Coverage Δ
AssimpKit/Code/Model/Tests/AssimpImporterTests.m 59.12% <100%> (-3.58%) ⬇️
AssimpKit/Code/Model/Tests/SCNSceneTests.m 81.81% <100%> (ø) ⬆️
AssimpKit/Code/Model/AssimpImporter.m 85.96% <100%> (-0.62%) ⬇️
AssimpKit/Code/Model/SCNNode+AssimpImport.m 0% <0%> (ø) ⬆️
AssimpKit/Code/Model/SCNScene+AssimpImport.m 70% <0%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbf10d...27408f4. Read the comment docs.

@dmsurti dmsurti merged commit ea2c252 into master Sep 1, 2017
@dmsurti dmsurti deleted the malloc-mem branch September 2, 2017 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants