Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename is32bit with a more precise name #79

Open
karya0 opened this issue Apr 29, 2015 · 3 comments
Open

Rename is32bit with a more precise name #79

karya0 opened this issue Apr 29, 2015 · 3 comments

Comments

@karya0
Copy link
Member

karya0 commented Apr 29, 2015

Looks like is32bit is a bad variable name when dealing with 32-bit binaries on 64-bit systems. We want something that says "it's a 32-bit binary on a 64-bit system". Is there a common convention that people use? If so, we can create a new variable that is set to true only in the said case and remains false otherwise.

@gc00
Copy link
Contributor

gc00 commented Apr 29, 2015

@karya0: Really good point.
What about isM32 or isMultiarch32?

For inspiration, I started looking at https://wiki.debian.org/Multiarch and: https://wiki.debian.org/Multiarch/LibraryPathOverview .

I found this paragraph:
To solve this problem, the GCC back-end may provide a secondary OS
multilib suffix which is used in place of the primary multilib suffix
for all library directories derived from system paths as opposed to
GCC paths. For example, in the typical bi-arch setup, the -m32 option is associated with the OS multilib suffix "../lib". Given the that primary
system library directory is /usr/lib64 on such systems, this has the
effect of causing the toolchain to search ...

@gc00
Copy link
Contributor

gc00 commented May 8, 2015

Still thinking about the right name. What about is32bitElfIn64bitOS?

@gc00
Copy link
Contributor

gc00 commented May 8, 2015

Also, a better design would be to set is32bitElf (or the new name) always to false when we're in a 32-bit Linux O/S. After pull request #97 (to fix a bug in 32-bit Linux), let's do a later pull request with this fix.
    (It's better to get DMTCP working correctly first, and then do polishing of the code in a later commit.)

gc00 pushed a commit to gc00/dmtcp that referenced this issue Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants