Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Version in Pull] Exception Processing Memory.AllowedSpeedsMhz #6

Closed
jbobzin-insyde opened this issue Aug 8, 2017 · 5 comments
Closed
Assignees

Comments

@jbobzin-insyde
Copy link

jbobzin-insyde commented Aug 8, 2017

The proposed pull version consistently has exception on Memory.AllowedSpeedsMhz[2666].
The exception is in routine process_list(), line 581 of rf_sut.py.
The program is looking for @odata.id in the 2666 numeric array element.
I have updated the local schema directory with files from 2016.3.

Here is failing page returned by the service.

{
    "@odata.context": "/redfish/v1/$metadata#Memory.Memory",
    "@odata.id": "/redfish/v1/Systems/BQWT64900010/Memory/Memory1",
    "@odata.type": "#Memory.v1_1_0.Memory",
    "Id": "Memory1",
    "Name": "Memory 1",
    "Description": "System Memory",
    "MemoryType": "DRAM",
    "MemoryDeviceType": "DDR4",
    "BaseModuleType": "RDIMM",
    "CapacityMiB": 8192,
    "DataWidthBits": 64,
    "Manufacturer": "Micron",
    "SerialNumber": "14F81054",
    "PartNumber": "18ASF1G72PZ-2G6B1   ",
    "AllowedSpeedsMHz": [
        2666
    ],
    "RankCount": 1,
    "DeviceLocator": "CPU0_DIMM_F1",
    "ErrorCorrection": "MultiBitECC",
    "OperatingSpeedMhz": 2666,
    "Metrics": {
        "@odata.id": "/redfish/v1/Systems/BQWT64900010/Memory/Memory1/MemoryMetrics"
    },
    "Status": {
        "State": "Enabled",
        "Health": "OK",
        "HealthRollup": "OK"
    }
}
@mraineri
Copy link
Contributor

Seems like this might be scope creep in the tool; the tool should be verifying the normative language in the spec, while the Service Validator tool verifies the JSON payloads conform to the schema.

@mraineri
Copy link
Contributor

Would like Bill and Tomas to work directly with Jeff to get some access to the system to debug the branch.

@jbobzin-insyde
Copy link
Author

send me private email at jeff.bobzin@insyde.com and I will reply with IP and logon

@billdodd
Copy link
Contributor

Jeff - an update:

I fixed the error with the "AllowedSpeedsMHz" list of integers. And a number of other errors I've found subsequently. I'm still in a loop of "run test -> get error -> fix error -> repeat". As soon as I get a clean run I'll commit my changes to the pending Pull Request.

@billdodd
Copy link
Contributor

billdodd commented Aug 24, 2017

Fix merged via #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants