Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfs_test/TEST_protocol_details.py needs some "defense" #63

Closed
PhillipWatts1012 opened this issue Jan 3, 2018 · 1 comment · Fixed by #64
Closed

rfs_test/TEST_protocol_details.py needs some "defense" #63

PhillipWatts1012 opened this issue Jan 3, 2018 · 1 comment · Fixed by #64
Assignees

Comments

@PhillipWatts1012
Copy link

about line 1160
query_url = json_payload['@odata.id'][:-1] + query_param
should be

                    try:
                        query_url = json_payload['@odata.id'][:-1] + query_param
                    except:
                        assertion_status = log.FAIL
                        log.assertion_log('line', "~ @odata.id  not found in redfish resource %s" % (relative_uris[relative_uri]))
                        continue

around line 3340
odata_id = (json_payload['@odata.id']).rsplit('/v1/', 1)[1]
should be

        try:
            odata_id = (json_payload['@odata.id']).rsplit('/v1/', 1)[1]
        except:
            assertion_status = log.FAIL
            log.assertion_log('line', "~ @odata.id  not found in redfish resource %s" )
            return assertion_status
@billdodd billdodd self-assigned this Jan 4, 2018
@billdodd
Copy link
Contributor

billdodd commented Jan 4, 2018

Thanks for reporting. Will correct to avoid the runtime exceptions and log the error when @odata.id is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants