Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Simplify Typescript instructions #281

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

NicholasBoll
Copy link
Contributor

Remove the /support in the import instructions removes the need to modify the tsconfig.json file.

While following the instructions, I noticed the package.json has a main entry that points to the support.js file while the types points to the index.d.ts file. Removing the /support from the instructions removes the need to modify the "types" in the tsconfig.json file. It makes everything simpler.

Remove the `/support` in the import instructions removes the need to modify the `tsconfig.json` file.
Copy link
Owner

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But here you are not changing not the build system at all nor the tsconfing, only readme, I do understand.
If you request changes it's not the place for the PR

Copy link
Owner

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK it looks like a correct change from some of the cypress breaking changes :D

@dmtrKovalenko dmtrKovalenko merged commit ff586ff into dmtrKovalenko:develop Nov 14, 2022
dmtrKovalenko pushed a commit that referenced this pull request Dec 27, 2022
Remove the `/support` in the import instructions removes the need to modify the `tsconfig.json` file.
@dmtrKovalenko
Copy link
Owner

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants