Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: js-joda support #589

Merged
merged 18 commits into from
Oct 4, 2021
Merged

Conversation

dspiteself
Copy link
Contributor

All tests pass and it seems to be working well from mui datepicker.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #589 (2468129) into master (0466222) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #589    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           14        16     +2     
  Lines         1176      1448   +272     
  Branches       136       186    +50     
==========================================
+ Hits          1176      1448   +272     
Impacted Files Coverage Δ
packages/js-joda/src/index.ts 100.00% <100.00%> (ø)
packages/js-joda/src/js-joda-utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0466222...2468129. Read the comment docs.

Copy link
Owner

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that coverage remains 100%

@dspiteself
Copy link
Contributor Author

Please make sure that coverage remains 100%

The Coverage should be back up. How to I get Codecov to rerun on the PR. I had to add a test file for the LocalDate specific type. That my not be the way you want to go. I could have 'parse' and 'date' always return LocalDateTime and just have date allow other TemporalTypes to be passed through.

@dmtrKovalenko
Copy link
Owner

dmtrKovalenko commented Sep 29, 2021

It should automatically run on CI, thanks I will figure it out.

@dmtrKovalenko
Copy link
Owner

Looks like CI is not happy, I will get back to your PR tomorrow

@dspiteself
Copy link
Contributor Author

Maybe it was me adding the dependency on
"cldr-data" : "^36.0.0", "cldrjs" : "^0.5.5"
for the outer project

@dmtrKovalenko dmtrKovalenko changed the title Add js-joda support to date-io feat: js-joda support Oct 4, 2021
@dmtrKovalenko dmtrKovalenko merged commit c694d02 into dmtrKovalenko:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants