-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: js-joda support #589
Conversation
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 14 16 +2
Lines 1176 1448 +272
Branches 136 186 +50
==========================================
+ Hits 1176 1448 +272
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure that coverage remains 100%
…add test coverage to that
The Coverage should be back up. How to I get Codecov to rerun on the PR. I had to add a test file for the LocalDate specific type. That my not be the way you want to go. I could have 'parse' and 'date' always return LocalDateTime and just have date allow other TemporalTypes to be passed through. |
It should automatically run on CI, thanks I will figure it out. |
Looks like CI is not happy, I will get back to your PR tomorrow |
Maybe it was me adding the dependency on |
All tests pass and it seems to be working well from mui datepicker.