Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(luxon): Use DateTime.isDateTime instead of instanceof #639

Merged
merged 1 commit into from
Jul 23, 2023
Merged

feat(luxon): Use DateTime.isDateTime instead of instanceof #639

merged 1 commit into from
Jul 23, 2023

Conversation

alex-kuck
Copy link
Contributor

The usage of DateTime.isDateTime should be more stable without breaking existing behavior. It also satisfies the current version constraints of luxon (added in 1.6.0).

@alex-kuck
Copy link
Contributor Author

For context: the current implementation using instanceof breaks, when two different versions of luxon are in use (accidentally discovered due to a misconfiguration of our bundler 😅 )

@flaviendelangle flaviendelangle mentioned this pull request Apr 24, 2023
Merged
@dmtrKovalenko dmtrKovalenko merged commit 24f0ded into dmtrKovalenko:master Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmtrKovalenko dmtrKovalenko dmtrKovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alex-kuck @dmtrKovalenko