Add decoded locations to test data

Consensys · Jan 14, 2020 · ab1cad8 · ab1cad8
1 parent 9024bec
commit ab1cad8
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 16 deletions.
diff --git a/tests/testdata/detected-issues-response.json b/tests/testdata/detected-issues-response.json
@@ -9,6 +9,18 @@
                     "tail": "It is possible to trigger an exception (opcode 0xfe). Exceptions can be caused by type errors, division by zero, out-of-bounds array access, or assert violations. Note that explicit `assert()` should only be used to check invariants. Use `require()` for regular input checking."
                 },
                 "severity": "Low",
+                "decodedLocations": [
+                  [
+                    {
+                      "column": 0,
+                      "line": 1
+                    },
+                    {
+                      "column": 23,
+                      "line": 1
+                    }
+                  ]
+                ],
                 "locations": [
                     {
                         "sourceMap": "454:1:1",

diff --git a/tests/testdata/detected-issues-sonar.json b/tests/testdata/detected-issues-sonar.json
@@ -1,18 +1,20 @@
 [
-  {
-    "linterName": "mythx",
-    "forRule": "SWC-110",
-    "ruleType": "LOW",
-    "remediationEffortMinutes": 0,
-    "severity": "LOW",
-    "message": "It is possible to trigger an exception (opcode 0xfe). Exceptions can be caused by type errors, division by zero, out-of-bounds array access, or assert violations. Note that explicit `assert()` should only be used to check invariants. Use `require()` for regular input checking."
-  },
-  {
-    "linterName": "mythx",
-    "forRule": "",
-    "ruleType": "LOW",
-    "remediationEffortMinutes": 0,
-    "severity": "LOW",
-    "message": "Warning: Free mode only detects certain types of smart contract vulnerabilities. Your contract may still be unsafe. Upgrade to MythX Pro to unlock the ability to test for even more vulnerabilities, perform deeper security analysis, and more. https://mythx.io/plans"
-  }
+    {
+        "linterName": "mythx",
+        "forRule": "SWC-110",
+        "ruleType": "LOW",
+        "remediationEffortMinutes": 0,
+        "atLineNr": 1,
+        "onInputFile": "/home/spoons/diligence/mythx-qa/land/contracts/estate/EstateStorage.sol",
+        "severity": "LOW",
+        "message": "It is possible to trigger an exception (opcode 0xfe). Exceptions can be caused by type errors, division by zero, out-of-bounds array access, or assert violations. Note that explicit `assert()` should only be used to check invariants. Use `require()` for regular input checking."
+    },
+    {
+        "linterName": "mythx",
+        "forRule": "",
+        "ruleType": "LOW",
+        "remediationEffortMinutes": 0,
+        "severity": "LOW",
+        "message": "Warning: Free mode only detects certain types of smart contract vulnerabilities. Your contract may still be unsafe. Upgrade to MythX Pro to unlock the ability to test for even more vulnerabilities, perform deeper security analysis, and more. https://mythx.io/plans"
+    }
 ]