Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing node_type check and renames node-specific class #12

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Adds missing node_type check and renames node-specific class #12

merged 1 commit into from
Oct 1, 2020

Conversation

PascalDierich
Copy link
Contributor

No description provided.

dmuhs
dmuhs approved these changes Oct 1, 2020
View reviewed changes
Copy link
Owner

@dmuhs dmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you! I'll release this right away as a patch. 🙂 Hopefully I'll have some time to hack up a test suite in the next days so that low-hanging issues like this get caught altogether.

@dmuhs dmuhs self-assigned this Oct 1, 2020
@dmuhs dmuhs merged commit ea0df54 into dmuhs:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmuhs dmuhs dmuhs approved these changes

Assignees

@dmuhs dmuhs

Labels
Priority: Medium Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PascalDierich @dmuhs