Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Centralite 3157100 thermostat quirks #127

Merged
merged 3 commits into from
Aug 10, 2019
Merged

Add Centralite 3157100 thermostat quirks #127

merged 3 commits into from
Aug 10, 2019

Conversation

presslab-us
Copy link
Contributor

This thermostat does not report battery_percentage_remaining,
like most other Centralite devices.
Use the existing code to convert from battery_voltage.

This thermostat does not report battery_percentage_remaining,
like most other Centralite devices.
Use the existing code to convert from battery_voltage.
@presslab-us
Copy link
Contributor Author

There is a pylint error Module name "3157100" doesn't conform to snake_case naming style (invalid-name), but it's named similar to the other files in that folder.

@dmulcahey
Copy link
Collaborator

@presslab-us
Copy link
Contributor Author

presslab-us commented Aug 10, 2019

I also found this which seems to work too. Which would you prefer? Is it required to be in the pylintrc file also if this is in the module file?
https://github.com/dmulcahey/zha-device-handlers/blob/52f480ee595d69f4629c35333436bbf73c0a3170/zhaquirks/centralite/3321S.py#L2

@dmulcahey
Copy link
Collaborator

Either one, I’ll eventually take a pass through all of this to clean this up.

@dmulcahey
Copy link
Collaborator

Thanks!

@dmulcahey dmulcahey merged commit ab480e9 into zigpy:dev Aug 10, 2019
@presslab-us presslab-us deleted the centralitetstat branch August 10, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants