Bad packet

[rourke750]

http://pastebin.com/Nz40Z1uz Getting that error, even though it says 1_72 this is still happening on newest versions of protical lib. Relevant code is here: https://github.com/Civcraft/AttrHider/blob/master/src/com/civpvp/attrhider/AttrHider.java . Is it something we are doing wrong or protical lib?

[dmulloy2]

The latest versions of ProtocolLib do not work with 1.7.x and under. Try build 10: http://ci.shadowvolt.com/job/ProtocolLib/10/

[rourke750]

This was happening through 1.7.2 - 1.7.10 is the code on our end look right at least? We got a lot of different stack traces Civcraft/AttrHider#2

[dmulloy2]

The code appears fine, although it looks to be an issue with the environment (wrong version/version mismatch with Spigot and ProtocolLib)

[rourke750]

Huh weird. We use orebfuscator too and that never seems to have an issue.
This was also across multiple versions.
On Jan 26, 2015 5:27 PM, "Dan Mulloy" notifications@github.com wrote:

The code appears fine, although it looks to be an issue with the
environment (wrong version/version mismatch with Spigot and ProtocolLib)

—
Reply to this email directly or view it on GitHub
#36 (comment).

[dmulloy2]

Is this still an issue?

[rourke750]

Yes.
On Jul 7, 2015 4:43 PM, "Dan Mulloy" notifications@github.com wrote:

Is this still an issue?

—
Reply to this email directly or view it on GitHub
#36 (comment)
.

[rourke750]

I can show you how to make it occur if you want?
On Jul 7, 2015 4:44 PM, "Rourke750" rourke7501@gmail.com wrote:

Yes.
On Jul 7, 2015 4:43 PM, "Dan Mulloy" notifications@github.com wrote:

Is this still an issue?

—
Reply to this email directly or view it on GitHub
#36 (comment)
.

[dmulloy2]

Ok sure

[rourke750]

So just download this http://build.civcraft.co:8080/job/AttrHider-master/ and bascily enchant some armor and click it on and off. Have enchanted weapons out. You also need to do this around players, the more players the more likely it will occur.

[dmulloy2]

I did that and wasn't able to reproduce this. Looking back over the stacks, it appears that ProtocolLib isn't actually involved. The only time it appears in the stack is when it passes the packet on. Those errors do generally appear with modded servers / clients, is your server modded by any chance?

[rourke750]

No its a normal server. We just use spigot. What did you do and for how
long to test it?
On Jul 7, 2015 8:01 PM, "Dan Mulloy" notifications@github.com wrote:

I did that and wasn't able to reproduce this. Looking back over the
stacks, it appears that ProtocolLib isn't actually involved. The only time
it appears in the stack is when it passes the packet on. Those errors do
generally appear with modded servers / clients, is your server modded by
any chance?

—
Reply to this email directly or view it on GitHub
#36 (comment)
.

[dmulloy2]

I put on fully enchanted armor with a fully enchanted sword and a few people around. I took it off and put it back on a few times. Are you sure this is actually caused by AttrHider and ProtocolLib?

[rourke750]

Yes, I'll make a video for you later tonight.
On Jul 8, 2015 1:11 PM, "Dan Mulloy" notifications@github.com wrote:

I put on fully enchanted armor with a fully enchanted sword and a few
people around. I took it off and put it back on a few times. Are you sure
this is actually caused by AttrHider and ProtocolLib?

—
Reply to this email directly or view it on GitHub
#36 (comment)
.

[rourke750]

Sorry about the late response here is the video and it shows you what error the client gets. Also the console just logs nullpointexception.

[dmulloy2]

Usually the client and/or server will produce some kind of error or crash. For servers, make sure debug=true is set in the server.properties. For the client, check the latest log in AppData/Roaming/.minecraft/logs

[rourke750]

Nothing appeared for either.

[dmulloy2]

I think the issue is with blocking health (line 86). In the video, it looks like you get disconnected after the player takes a good bit of damage. Try removing and/or modifying that section and see if it helps.

[rourke750]

Removing it didn't help. From some logging it seems like it's actually the equipment stuff on line 52. Also do these stacks help at all.

[dmulloy2]

Does removing the equipment stuff help?

[rourke750]

I don't recall. I do believe the issue is being caused bu this line but it shouldnt matter. Any ideas?

[dmulloy2]

Someone else on the Spigot forums had an issue similar to this. Does this error still occur without ProtocolLib?

[rourke750]

This error does not occur without protical lib as it will not function without it.

[dmulloy2]

Is this still an issue in 3.6.5, 3.7.0, or 4.0.0?

[rourke750]

Oh my bad, yea seems to be fixed.