Failing to clone entity metadata packets in 1.14, 1.14.1, 1.4.2. Latest ProtocolLib dev version.

[Niall7459]

Follow this template except for feature requests. Use pastebin when providing /protocol dump and any relevant errors.

Make sure you've done the following:

• You're using the latest build for your server version
• This isn't an issue caused by another plugin
• You've checked for duplicate issues
• You didn't use /reload

Debug paste link:
Multiple:
https://pastebin.com/M5zqwUkd
https://pastebin.com/PAt8MCjU
https://pastebin.com/cDfU1rwc

Description and relevant errors:

Issue cloning PacketPlayOutEntityMetadata. I'm pretty sure this isn't an issue on my side. Any information for anything that needs changing for 1.14 would be great. Thank you.

Packet Event Listener:

    @Override
    public void onPacketSending(PacketEvent event) {
        PacketContainer packet = event.getPacket();

        if (packet.getType() != PacketType.Play.Server.ENTITY_METADATA) {
            return;
        }

        WrapperPlayServerEntityMetadata entityMetadataPacket = new WrapperPlayServerEntityMetadata(packet.deepClone());
        List<WrappedWatchableObject> dataWatcherValues = entityMetadataPacket.getEntityMetadata();

        for (WrappedWatchableObject watchableObject : dataWatcherValues) {
            if (watchableObject.getIndex() == 2) {
                if (replacePlaceholders(watchableObject, event.getPlayer())) {
                    event.setPacket(entityMetadataPacket.getHandle());
                }
                return;
            }
        }
    }

[dmulloy2]

Multicraft is cutting out the useful part of the stack:
08.06 00:04:44 [Multicraft] Skipped 76 lines due to rate limit (30/s)

Can you get a complete one?

[HexedHero]

https://cdn.hexedhero.com/u/bUz5Nh1kJF.log

[Brokkonaut]

I have something similar: https://pastebin.com/raw/hBcMJd1t

[dmulloy2]

Thanks! I'll fix those when I get the chance, hopefully soon-ish

[Niall7459]

Hey, just wondering if there’s any progress on this or when we can see the fix implemented?

Regards

[WulfTheGod]

Spams this error multiple times in console.
https://pastebin.com/rXijkPSx
Only happens when players interact with HDs.

[HexedHero]

Please fix?

[dmulloy2]

Sorry, was really busy the last few months. Working on it now.

[HexedHero]

Sorry, was really busy the last few months. Working on it now.

Finally, thank the lord !

[successed]

WHY CLOSED İSSUE ?

http://bin.shortbin.eu:8080/QggbCzj5hk

[HexedHero]

WHY CLOSED İSSUE ?

http://bin.shortbin.eu:8080/QggbCzj5hk

It's literally fixed, go update.

[WulfTheGod]

I am updated with everything and the issue still persists.
https://pastebin.com/LM1xdpR0