Fixed setting Base64 favicon for 1.19.4 or later #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
lgtm. would be good to have a unit test or 2 to verify |
dmulloy2
approved these changes
Dec 19, 2023
dmulloy2
force-pushed
the
fix-favicon
branch
from
ff0fbd0
to
29fe61b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes setting favicons of server ping. Currently, the image data is encoded to base64 twice resulting in an invalid image sent to the client. This also slightly improves performance as the raw image does not get converted to Base64 in cases that do not require it.
Fixes #2511, #2354