improve support for custom payloads in 1.20.2 #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gonna put this into draft until I implemented a way to read data from every CustomPayload implementation, not only the Spigot specific "UnknownPayload" |
|
Now any kind of custom payload can be read using |
derklaro
changed the title
|
@dmulloy2 When will this be merged? Should I directly build and use this PR? |
dmulloy2
approved these changes
Oct 25, 2023
dmulloy2
force-pushed
the
better-payload-test
branch
from
83c5900
to
5c606ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a full test for custom payloads to be serialized and deserialized correctly by:
This test now properly ensures that (de-) serializing a custom payload works as expected over the wire. Previous tests only captured deserialize and cloning.