Add MCP packet names for Bukkit-Forge hybrid server

[NewbieOrange]

Fix ProtocolLib returning dynamic PacketType on forge servers, which breaks plugin using PacketType enums.

This PR will fix #858.

[NewbieOrange]

It seems that we cannot get reliable name on forge servers (which is expected). Adding PacketType lookup using packet id as a fallback will fix the issue.

I think adding such a fallback will not hurt reliablity or performance. Any thoughts?

[dmulloy2]

it wouldn’t have that much of an impact on performance. my main consideration is that packet ids change just about every version, so the 1.15 packet ids aren’t the same as the forge/1.12 ids

[dmulloy2]

it might be worthwhile to generate a mapping of forge packet names

[NewbieOrange]

I am looking into it and trying to figure out what could be done.

[NewbieOrange]

Hi @dmulloy2,

I have added some forge packet names and helper functions. I have tested this with FastLogin and it works.

Any thoughts? If you think this is doable, I will finish adding the rest of packet names.

[NewbieOrange]

I have added all MCP & Forge packet names up to 1.12.

[NewbieOrange]

Note that these names only works for minecraft 1.12. MC 1.13 and 1.14 both have different packet names. Considering that CatServer / Magma is still at 1.12 so far, this should be sufficient.

[NewbieOrange]

I have tested this and it works flawlessly with CatServer. I suppose it should work for Magma too, but not tested.

[Luohuayu]

I have tested this and it works flawlessly with CatServer. I suppose it should work for Magma too, but not tested.

Luohuayu/CatServer#208 (comment)

[Luohuayu]

@NewbieOrange It seems still some problems

[NewbieOrange]

The changes is not in the release version. Try the lastest snapshot (461+). @Luohuayu