Improve StreamSerializer ItemStack methods #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to and from byte arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced duplicated code and created methods for (de)serialization with byte arrays.
There are no functional changes, but two new methods:
byte[] serializeItemStackToByteArray(ItemStack stack) throws IOExceptionItemStack deserializeItemStackFromByteArray(byte[] input) throws IOExceptionDesign part:
Up till now the serialize base64 implementation did two things (serialization and base64 encoding), they are now separated.
As it is now, you don't have to use a deprecated method or encode your byte[] to base64 only to let it be decoded again.
I'm not too sure about the naming, but it should be decent.