Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List documents #31

Merged
merged 3 commits into from
Jan 13, 2020
Merged

List documents #31

merged 3 commits into from
Jan 13, 2020

Conversation

dmurvihill
Copy link
Owner

Reopening the original PR here.

@dmurvihill dmurvihill mentioned this pull request Nov 19, 2019
Open
@dmurvihill
Copy link
Owner Author

Tagging @joelpoloney as he expressed interest in this change.

@dmurvihill dmurvihill moved this from To do to In progress in Dispose of existing pull requests Nov 20, 2019
dmurvihill
dmurvihill commented Nov 20, 2019
View reviewed changes
Copy link
Owner Author

@dmurvihill dmurvihill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally left feedback on the other PR.

@dmurvihill dmurvihill mentioned this pull request Nov 20, 2019
Merged
dmurvihill
dmurvihill commented Jan 13, 2020
View reviewed changes
Copy link
Owner Author

@dmurvihill dmurvihill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to punt the issue of admin versus regular SDK to version 4. Merging.

@dmurvihill
Merge branch 'master' into list-documents
4dd67a7 
# Conflicts:
#	test/unit/firestore-collection.js
@dmurvihill dmurvihill merged commit ee51273 into master Jan 13, 2020
Dispose of existing pull requests automation moved this from In progress to Done Jan 13, 2020
@dmurvihill dmurvihill deleted the list-documents branch January 13, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Dispose of existing pull requests
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmurvihill @op