Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSPileupUtils: Use MSPileupUtils getPileupDocs for other implementations #11909

Closed
d-ylee opened this issue Feb 21, 2024 · 3 comments · Fixed by #11910
Closed

MSPileupUtils: Use MSPileupUtils getPileupDocs for other implementations #11909

d-ylee opened this issue Feb 21, 2024 · 3 comments · Fixed by #11910
Assignees

Comments

@d-ylee
Copy link
Contributor

d-ylee commented Feb 21, 2024

Impact of the new feature
MicroServices, MSTransferor
WorkflowUpdator

Is your feature request related to a problem? Please describe.
MSPileup getPileupDocs has been refactored into WMCore.Services.MSPileup.MSPileupUtils.getPileupDocs. Other implementations (i.e. in Tools.Common, MSTransferor), should be replaced and deprecated.

Describe the solution you'd like
Replace other implementations of getPileupDocs. Deprecate the other implementations.

Tools.Common (to be deprecated)

def getPileupDocs(mspileupUrl, queryDict):

MSTransferor

from WMCore.MicroService.Tools.Common import (teraBytes, isRelVal, getPileupDocs)

WorkflowUpdater

Describe alternatives you've considered
N/A

Additional context
Related to following closed issues/PR:
#11891
#11870
#11879

@d-ylee d-ylee self-assigned this Feb 21, 2024
@vkuznet
Copy link
Contributor

vkuznet commented Feb 21, 2024

@d-ylee , could you please elaborate more the reason for such Service and what exactly such service will do? Are you asking to have dedicate MicroService to fetch docs from MSPIleup MongoDB? or are you suggesting new end-point(s) within existing MSPileup service. Honestly, I do not understand the suggested idea.

@d-ylee
Copy link
Contributor Author

d-ylee commented Feb 21, 2024

@vkuznet Sorry, I think I missworded it. I meant that the function itself has been refactored under WMCore.Services.MSPileup.MSPileupUtils.getPileupDocs. The function is being used in multiple areas. Will update the description.

@vkuznet
Copy link
Contributor

vkuznet commented Feb 22, 2024

@d-ylee , thanks for clarification, now it make sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment