Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 11909 Uses MSPileupUtils getPileupDocs in all Instances #11910

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Fix 11909 Uses MSPileupUtils getPileupDocs in all Instances #11910

merged 2 commits into from
Feb 26, 2024

Conversation

d-ylee
Copy link
Contributor

@d-ylee d-ylee commented Feb 21, 2024

Fixes #11909

Status

Not tested

Description

Replaces getPileupDocs in MSTransferor and WorkflowUpdatorPoller with MSPileupUtils.getPileupDocs

Is it backward compatible (if not, which system it affects?)

MAYBE

Related PRs

#11905

External dependencies / deployment changes

N/A

@d-ylee d-ylee self-assigned this Feb 21, 2024
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 289 new failures
    • 1 tests no longer failing
    • 12 changes in unstable tests
  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 10 warnings
    • 111 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 34 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14905/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 2 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 10 warnings
    • 111 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 34 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14906/artifact/artifacts/PullRequestReport.html

@d-ylee d-ylee requested a review from amaltaro February 22, 2024 21:06
amaltaro
amaltaro requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-ylee Dennis, this code is looking good in general. However, I left a couple of suggestions along the code. Once you make those modifications, feel free to squash commits please.

src/python/WMCore/MicroService/Tools/Common.py Outdated Show resolved Hide resolved
src/python/WMCore/MicroService/Tools/Common.py Outdated Show resolved Hide resolved
src/python/WMComponent/WorkflowUpdater/WorkflowUpdaterPoller.py Outdated Show resolved Hide resolved
@d-ylee d-ylee force-pushed the 11909-mspileuputils-use-mspileuputils-getpileupdocs-for-other-implementations branch from 9d8c3fa to 8aa91e5 Compare February 26, 2024 21:31
@d-ylee d-ylee requested a review from amaltaro February 26, 2024 21:32
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 1 warnings and errors that must be fixed
    • 10 warnings
    • 109 comments to review
  • Pylint py3k check: failed
    • 2 warnings
  • Pycodestyle check: succeeded
    • 33 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14919/artifact/artifacts/PullRequestReport.html

@d-ylee d-ylee force-pushed the 11909-mspileuputils-use-mspileuputils-getpileupdocs-for-other-implementations branch from 8aa91e5 to d4de61b Compare February 26, 2024 21:51
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
    • 10 warnings
    • 108 comments to review
  • Pylint py3k check: failed
    • 2 warnings
  • Pycodestyle check: succeeded
    • 33 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14920/artifact/artifacts/PullRequestReport.html

@d-ylee
Copy link
Contributor Author

d-ylee commented Feb 26, 2024

@amaltaro I have made the recommended changes and squashed the changes.

amaltaro
amaltaro approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dennis!

@amaltaro amaltaro merged commit 6be7729 into dmwm:master Feb 26, 2024
2 of 4 checks passed
This was referenced Mar 15, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaltaro amaltaro amaltaro approved these changes

Assignees

@d-ylee d-ylee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSPileupUtils: Use MSPileupUtils getPileupDocs for other implementations
3 participants
@d-ylee @cmsdmwmbot @amaltaro